Skip to content

feat: add .astro files to custom types#446

Closed
MichaelDeBoey wants to merge 2 commits intojshttp:masterfrom
MichaelDeBoey:patch-4
Closed

feat: add .astro files to custom types#446
MichaelDeBoey wants to merge 2 commits intojshttp:masterfrom
MichaelDeBoey:patch-4

Conversation

@MichaelDeBoey
Copy link

No description provided.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve asked in the Astro Discord to see if a maintainer can help us with this. I’m not sure whether this is necessary, but having someone from Astro here could help with the discussion.

@lloydjatkinson
Copy link

I see literally no reason to add these at all, nor do I for the linked .svelete and .vue PRs. The "reason" given in the other PR's doesn't make any sense.

@jonchurch
Copy link
Member

See #445 (comment)

@jonchurch jonchurch closed this Feb 28, 2026
@MichaelDeBoey
Copy link
Author

According to @OliverSpeir's Discord response, it should be text/plain instead

@bjohansebas
Copy link
Member

But that’s not the official MIME type. We were just discussing which one would be the most appropriate if that were the case. In any case, this would only matter if that Astro file were being sent over the internet,but those files aren’t meant to be served over the internet, or am I mistaken?

It would be better to reach a consensus within Astro, since that was only the opinion of one Astro contributor and doesn’t represent the whole project. So the best approach would be to open an issue so everyone can agree on it, and either register it through IANA or clearly document which MIME type should be considered the reliable source.

@MichaelDeBoey
Copy link
Author

MichaelDeBoey commented Mar 1, 2026

this would only matter if that Astro file were being sent over the internet

In a project I'm working on, we enable people to sent .astro (and .svelte & .vue) files over the internet and we want to do extra things for each one of them

In the meantime, I've opened withastro/docs#13335 so we could wait for an official consensus from their side

@bjohansebas
Copy link
Member

Okay, cool, it’s always good to understand the use case. As you know, for anything you want to add, there needs to be an official source. So you’ll need to do the same for the other frameworks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants